-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Movie Accurate M10s #173
Movie Accurate M10s #173
Conversation
Can you post a screenshot? I don't think I've seen what these look like. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I like the change. Looks neato. If you would like to adjust accessories so they look right with the cam, go for it. It's on auto-merge, when you fix the icon conflict. |
Aight, will do! |
Head branch was pushed to by a user without write access
Conflicts have been resolved. A maintainer will review the pull request shortly. |
looks like this is still reverting amory's sprite changes to other headgear like the boonie according to iconbot |
I wasn't aware he made changes to the softcap headgear so when I get back home I'll match sure to patch those in. |
Alright, that should fix this PR. |
You're still overriding the new PO helmet, and desert cap and its flipped state with the old shading. I will also say, I'm not sure why you're integrating a mic into the helmet when we have a earpiece system. Adding a mic piece communicates something that doesn't exist. The helmets do have camera functionality, they don't have earpiece functionality. |
This reverts commit 9fc88cd.
Added the PO helmet and new desert patrol cap. The changes are there to provide an aesthetic change to match that of the movie this project is based on. While yes, the helmet doesn't have a built in radio function code wise, that could be changed in the future. |
Hmmm... Okay, we will TM this and see what that does. I'm fine with the helmet ear pieces, and in fact may be something we will do in the future. But if it's out of place, we probably want to remove that before merging it in proper. |
Cooking |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still a todo, i know. just for the code currently
Played three rounds with it. Not really a fan. Visible camera is good, but I don't like how the headset bit is integrated. It's palette is very bland, and it does look like a helmet strap. Obviously I'm biased because I have my own sprites but I also just don't think it's that great to have it integrated with the helmet when you can just have visible headsets beneath to achieve the same outcome with much more versatility. |
I'd prefer if the headsets are around as surplus uniform vendors if anyone doesn't want to wear a helmet or those who never have a helmet in the first place. |
Gotta figure out how I want to handle some of the icons with multiple suffixes. So SoonTM. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
stale for more than a month, author seems to be inactive |
Adds new M10 sprites for Riflemen, SGTs, and Corpsmen that is more accurate to the movies. Old sprites are still there, now just no longer used.
Also adds integrated headset component to allow for attaching headsets to headgear. Shown: https://www.youtube.com/watch?v=V34R6HBdFb0